+(*)Restore ability to use decomposed restart files #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added optional MOM_Domain arguments to the 0-d and 1-d versions of MOM_read_data, enabling them to read from a domain-decomposed file if the single file is not present. The MOM_read_data calls in restore_state were modified to use these new optional arguments, thereby restoring the ability of MOM6 to read from domain-decomposed restart files, which had been broken by a known miscreant on January 3, 2021 with MOM6 commit aea16f7. All answers and output are bitwise identical in cases that worked.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1318 +/- ##
============================================
- Coverage 45.77% 45.77% -0.01%
============================================
Files 234 234
Lines 72507 72513 +6
============================================
Hits 33193 33193
- Misses 39314 39320 +6
Continue to review full report at Codecov.
|
|
Looks good, tests are passing. I'm expecting we'll discuss on Monday how to modify the test suite to catch these in the future. |
marshallward
approved these changes
Feb 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional MOM_Domain arguments to the 0-d and 1-d versions of
MOM_read_data, enabling them to read from a domain-decomposed file if the single
file is not present. The MOM_read_data calls in restore_state were modified to
use these new optional arguments, thereby restoring the ability of MOM6 to read
from domain-decomposed restart files, which had been broken by a known miscreant
on January 3, 2021 with MOM6 commit aea16f7. All answers and output are
bitwise identical in cases that worked.