+Cleaned up MOM_inter_infra argument documentation #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the MOM_inter_infra argument declarations to follow the usual pattern for the declaration of optional arguments in MOM6 code. Also eliminated an optional argument to horiz_inter_from_weights that was only described as "unknown" always hard-coded to .true. in all calls from the MOM6 code. All answers are bitwise identical, but one optional argument was removed.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1321 +/- ##
============================================
+ Coverage 45.49% 45.76% +0.27%
============================================
Files 234 234
Lines 72527 72524 -3
============================================
+ Hits 32995 33192 +197
+ Misses 39532 39332 -200
Continue to review full report at Codecov.
|
marshallward
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the MOM_inter_infra argument declarations to follow the usual pattern
for the declaration of optional arguments in MOM6 code. Also eliminated an
optional argument to horiz_inter_from_weights that was only described as
"unknown" always hard-coded to .true. in all calls from the MOM6 code.
All answers are bitwise identical, but one optional argument was removed.