Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trailer.py PEP8/PEP257 cleanup #1323

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

marshallward
Copy link
Collaborator

This patch cleans up the trailer.py tool to conform to the PEP8 and
PEP257 Python style guides:

https://www.python.org/dev/peps/pep-0008/

https://www.python.org/dev/peps/pep-0257/

Specifically, the pycodestyle and pydocstyle tools no longer report
any nonconformance, and report the script as passing.

This patch cleans up the trailer.py tool to conform to the PEP8 and
PEP257 Python style guides:

    https://www.python.org/dev/peps/pep-0008/

    https://www.python.org/dev/peps/pep-0257/

Specifically, the `pycodestyle` and `pydocstyle` tools no longer report
any nonconformance, and report the script as passing.
@marshallward marshallward requested a review from adcroft February 11, 2021 17:47
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #1323 (4c3ef14) into dev/gfdl (d572fd5) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/gfdl    #1323      +/-   ##
============================================
- Coverage     45.79%   45.76%   -0.04%     
============================================
  Files           234      234              
  Lines         72472    72524      +52     
============================================
  Hits          33192    33192              
- Misses        39280    39332      +52     
Impacted Files Coverage Δ
src/diagnostics/MOM_obsolete_diagnostics.F90 84.84% <0.00%> (-7.46%) ⬇️
src/framework/MOM_diag_manager_infra.F90 48.64% <0.00%> (-1.36%) ⬇️
src/framework/MOM_interp_infra.F90 69.56% <0.00%> (-0.65%) ⬇️
src/framework/MOM_coms_infra.F90 59.42% <0.00%> (ø)
src/tracer/MOM_generic_tracer.F90 0.00% <0.00%> (ø)
src/framework/MOM_ensemble_manager_infra.F90 27.77% <0.00%> (ø)
src/framework/MOM_horizontal_regridding.F90 60.23% <0.00%> (+0.04%) ⬆️
src/framework/MOM_diag_mediator.F90 66.43% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d572fd5...4c3ef14. Read the comment docs.

@adcroft adcroft merged commit 4ea2f71 into mom-ocean:dev/gfdl Feb 17, 2021
@marshallward marshallward deleted the trailer_py_pep8 branch May 7, 2021 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants