Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a missing line regarding vel_underflow #1340

Merged

Conversation

herrwang0
Copy link
Contributor

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #1340 (8d0a80f) into dev/gfdl (f06669e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev/gfdl    #1340   +/-   ##
=========================================
  Coverage     45.75%   45.75%           
=========================================
  Files           234      234           
  Lines         72555    72556    +1     
=========================================
+ Hits          33194    33195    +1     
  Misses        39361    39361           
Impacted Files Coverage Δ
src/core/MOM_barotropic.F90 68.03% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06669e...fb882c9. Read the comment docs.

@marshallward
Copy link
Collaborator

marshallward commented Mar 2, 2021

Copy link
Collaborator

@marshallward marshallward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A straightforward fix, restores symmetry of the underflow operation.

@marshallward marshallward merged commit a545274 into mom-ocean:dev/gfdl Mar 2, 2021
@herrwang0 herrwang0 deleted the fix-vel_underflow-missingline branch September 25, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants