Initialise advection progress arrays, closes #134. #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a good catch! This change should not alter any answers because if the flag was accidentally set to .true. during initialization, the loop would still have 0 fluxes and not change the tracers. However, this change could improve the efficiency of the code by avoiding unnecessary calculations. |
Hallberg-NOAA
added a commit
to Hallberg-NOAA/MOM6
that referenced
this pull request
Jun 29, 2017
Modified MOM_state_initialization and all of the thickness, temperature, and velocity initialization routines it calls so that the relevant routines are always called, regardless of whether this run segment is for a new run or started from a restart file, so that all valid parameters are read. This will enable detection of misspelled or invalid runtime parameters without requiring that the MOM input files be changed between run segments. Several MOM_parameter_doc files have been changed by the addition of missing log_version calls for some initialization routines. All answers are bitwise identical, but there are new optional arguments to numerous intialization routines. This commit addresses and should close NOAA-GFDL/MOM6-examples Issue mom-ocean#135.
nikizadehgfdl
pushed a commit
to nikizadehgfdl/MOM6
that referenced
this pull request
Oct 9, 2017
- Last commit closes mom-ocean#135. NOAA-GFDL/MOM6@249e9f6 Merge branch 'Hallberg-NOAA-dev/gfdl' into dev/gfdl NOAA-GFDL/MOM6@74bcc77 Merge branch 'dev/gfdl' of https://github.com/Hallberg-NOAA/MOM6 into Hallberg-NOAA-dev/gfdl NOAA-GFDL/MOM6@83f606a Merge pull request mom-ocean#536 from adcroft/fix-gnu-openmp-490 NOAA-GFDL/MOM6@5f0fec7 Removed trailing white space NOAA-GFDL/MOM6@530fea2 +Made OS argument to ocean_model_flux_init optional NOAA-GFDL/MOM6@e6b7df2 +Always call initialization routines to get_params NOAA-GFDL/MOM6@9c3ff33 Merge pull request mom-ocean#535 from adcroft/fix-hor-visc-openmp NOAA-GFDL/MOM6@76bd4d4 Renames "mod" variable to avoid using imod() fn NOAA-GFDL/MOM6@d69ca55 Fixes openmp directives for Leith mods NOAA-GFDL/MOM6@0c4f909 Merge pull request mom-ocean#534 from adcroft/correct-horizontal-indexing-schematics NOAA-GFDL/MOM6@97c8f81 Corrects schematic of symmetric arrays NOAA-GFDL/MOM6@8d8ad81 Merge pull request mom-ocean#533 from CarolineCardinale/dev/gfdl NOAA-GFDL/MOM6@2cccc6a Merge pull request mom-ocean#530 from adcroft/document-fox-kemper NOAA-GFDL/MOM6@86786a5 Added Doxygen comments to subroutines NOAA-GFDL/MOM6@b616fbd Merge branch 'dev/gfdl' of https://github.com/NOAA-GFDL/MOM6 into dev/gfdl NOAA-GFDL/MOM6@40a7aed Added Doxygen comments to subroutines NOAA-GFDL/MOM6@d2e6771 Merge branch 'dev/gfdl' of https://github.com/NOAA-GFDL/MOM6 into dev/gfdl NOAA-GFDL/MOM6@0b961d1 Added doxumentation for the Fox-Kemper scheme NOAA-GFDL/MOM6@86972b5 Added doxygen comments to subroutines NOAA-GFDL/MOM6@0d5399f Merge branch 'dev/gfdl' of https://github.com/NOAA-GFDL/MOM6 into dev/gfdl NOAA-GFDL/MOM6@26ed48b Added doxygen comments to MOM_wave_structure.F90 NOAA-GFDL/MOM6@154877e Added doxygen comments to MOM_sum_output.F90 NOAA-GFDL/MOM6@c8cdb04 Added doxygen comments to MOM_PointAccel.F90 NOAA-GFDL/MOM6@3fdcb86 Added doxygen comments to MOM_diagnostics.F90 NOAA-GFDL/MOM6@e9b0a48 Added doxygen comments to MOM_diag_to_Z.F90 NOAA-GFDL/MOM6@0356c63 Added doxygen comments to MOM_domains.F90 NOAA-GFDL/MOM6@9aa01c9 Merge branch 'dev/gfdl' of https://github.com/NOAA-GFDL/MOM6 into dev/gfdl NOAA-GFDL/MOM6@5c49c2d Added doxygen comments to MOM_OCMIP_CFC.F90 NOAA-GFDL/MOM6@64b35c3 Added doxygen comments to MOM_legacy_barotropic.F90
gustavo-marques
pushed a commit
to gustavo-marques/MOM6
that referenced
this pull request
Dec 31, 2019
Merge Lateral Boundary Diffusion module
jiandewang
added a commit
that referenced
this pull request
Sep 14, 2024
initialize cpl_scalar field when created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.