Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(*)Use depths in DOME and dye tracer initialization #1482

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

Hallberg-NOAA
Copy link
Collaborator

Initialize the horizontal stripes of tracers in the DOME and dye examples
based on the depth from the (flat) sea surface rather than the height above the
seafloor. These are mathematically equivalent, but there could be small changes
in the tracer distributions. Because these changes only impact passive tracers,
all of the physical solutions are bitwise identical.

  Initialize the horizontal stripes of tracers in the DOME and dye examples
based on the depth from the (flat) sea surface rather than the height above the
seafloor.  These are mathematically equivalent, but there could be small changes
in the tracer distributions.  Because these changes only impact passive tracers,
all of the physical solutions are bitwise identical.
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #1482 (2ad1c15) into dev/gfdl (5666854) will increase coverage by 0.00%.
The diff coverage is 23.52%.

❗ Current head 2ad1c15 differs from pull request most recent head 72a084e. Consider uploading reports for the commit 72a084e to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           dev/gfdl    #1482   +/-   ##
=========================================
  Coverage     29.13%   29.14%           
=========================================
  Files           235      235           
  Lines         71077    71081    +4     
=========================================
+ Hits          20711    20713    +2     
- Misses        50366    50368    +2     
Impacted Files Coverage Δ
src/tracer/dye_example.F90 0.00% <0.00%> (ø)
src/tracer/DOME_tracer.F90 46.77% <57.14%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5666854...72a084e. Read the comment docs.

@marshallward
Copy link
Collaborator

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13479 ✔️

@marshallward marshallward merged commit 13fdbf0 into mom-ocean:dev/gfdl Aug 30, 2021
@Hallberg-NOAA Hallberg-NOAA deleted the DOME_tracer_init_depth branch November 22, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants