+(*)Add ALTERNATE_FIRST_DIRECTION #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new runtime parameter, ALTERNATE_FIRST_DIRECTION, to cause the first direction in the directionally split operators (such as the continuity solver, the barotropic solver, and the tracer advection) to alternate with every dynamic timestep. This includes changes to record this direction in the restart file, so that the model will reproduce across restarts. In addition a previously uninitialized logical in offline_advection_layer is now being initialized similarly to other similar variables in the MOM_offline_main module. By default, all answers in the MOM6-examples are bitwise identical, but there is a new runtime parameter and a new non-mandatory field in the MOM6 restart files, and there might be changes in offline tracer advection runs.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1501 +/- ##
=========================================
Coverage 29.05% 29.06%
=========================================
Files 237 237
Lines 71629 71645 +16
=========================================
+ Hits 20812 20822 +10
- Misses 50817 50823 +6
Continue to review full report at Codecov.
|
marshallward
reviewed
Oct 1, 2021
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/jobs/69534 ✔️ 🟠 New parameter:
|
marshallward
approved these changes
Oct 1, 2021
herrwang0
reviewed
Oct 14, 2021
| call set_first_direction(G, NINT(CS%first_dir_restart)) | ||
| ! Store the first direction for the next time a restart file is written. | ||
| CS%first_dir_restart = real(G%first_direction) | ||
|
|
There was a problem hiding this comment.
Just found a bug that First_direction from restart is not used, and it is traced back to this piece of code.
I think this section of added code is misplaced; it is within the if(CS%rotate_index) block. Should it be moved outside?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new runtime parameter, ALTERNATE_FIRST_DIRECTION, to cause the first
direction in the directionally split operators (such as the continuity solver,
the barotropic solver, and the tracer advection) to alternate with every dynamic
timestep. This includes changes to record this direction in the restart file,
so that the model will reproduce across restarts. In addition a previously
uninitialized logical in offline_advection_layer is now being initialized
similarly to other similar variables in the MOM_offline_main module. By
default, all answers in the MOM6-examples are bitwise identical, but there is a
new runtime parameter and a new non-mandatory field in the MOM6 restart files,
and there might be changes in offline tracer advection runs.