Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFDL to main 2022-07-21 #1577

Merged
merged 83 commits into from
Jul 29, 2022
Merged
Show file tree
Hide file tree
Changes from 82 commits
Commits
Show all changes
83 commits
Select commit Hold shift + click to select a range
548be25
Remove unused module use for calculate_density
Hallberg-NOAA Apr 26, 2022
9c2e573
Document variables in diagnoseMLDbyEnergy
Hallberg-NOAA Apr 26, 2022
07df0bf
Clarify units for equation of state arguments
Hallberg-NOAA Apr 26, 2022
3a9d511
Revise how the drho_dT diagnostic is calculated
Hallberg-NOAA Apr 26, 2022
75ebb40
+Refactored MOM_density_integrals
Hallberg-NOAA Apr 26, 2022
f513554
Clarify argument units for int_density_dz_wright
Hallberg-NOAA Apr 27, 2022
0903609
+Make equation of state interfaces more consistent
Hallberg-NOAA Apr 27, 2022
f52c40a
Fix a bug in the rescaling of drho_dT_dP
Hallberg-NOAA Apr 27, 2022
5d88f2e
Modify units in temperature and salinity comments
Hallberg-NOAA May 1, 2022
b8e5990
+Temperature and salinity rescaling in MOM_EOS.F90
Hallberg-NOAA May 3, 2022
14a222e
Use simpler calculate_TFreeze interfaces
Hallberg-NOAA May 3, 2022
47f1392
Modify more units in temperature and saln comments
Hallberg-NOAA May 3, 2022
44a7861
+Add scale argument to set_up_ALE_sponge
Hallberg-NOAA May 3, 2022
5a89a9d
+Add rescaling for temperature and salinity (1)
Hallberg-NOAA May 3, 2022
6d78d2b
+Add rescaling for temperature and salinity (2)
Hallberg-NOAA May 3, 2022
31d4117
Correct a few more temperature and salin units
Hallberg-NOAA May 8, 2022
2a362c4
Merge branch 'dev/gfdl' into EOS_interface_cleanup
Hallberg-NOAA May 11, 2022
30d3e70
Merge branch 'EOS_interface_cleanup' into EOS_rescale_prep
Hallberg-NOAA May 11, 2022
b3c41b1
+Rescale vars in MOM_temp_salt_initialize_from_Z
Hallberg-NOAA May 12, 2022
d4ccf56
Fix data read for on-grid interpolation
angus-g May 16, 2022
079fd3e
+Add cons_temp_to_pot_temp & abs_saln_to_prac_saln
Hallberg-NOAA May 16, 2022
1c66964
Rescaled dumbbell_initialize_thickness salinities
Hallberg-NOAA May 18, 2022
9d6def6
Merge pull request #118 from Hallberg-NOAA/EOS_interface_cleanup
marshallward May 19, 2022
cf448a1
MOM_file_parser unit test implementation
marshallward Dec 6, 2021
9292b58
Merge pull request #119 from marshallward/unittest
Hallberg-NOAA May 20, 2022
0b05686
Fix bugs in output files with rescaled heights
Hallberg-NOAA May 3, 2022
4767046
Merge branch 'dev/gfdl' into EOS_rescale_prep
marshallward May 22, 2022
a965005
Merge pull request #122 from Hallberg-NOAA/EOS_rescale_prep
marshallward May 22, 2022
b31ec83
Merge branch 'dev/gfdl' into fix-ongrid-interp
Hallberg-NOAA May 25, 2022
af321d6
Merge pull request #124 from angus-g/fix-ongrid-interp
Hallberg-NOAA May 26, 2022
2b5b438
+Add optional scale argument to time_interp_external
Hallberg-NOAA May 16, 2022
8b51305
Simplify set_grid_metrics_from_mosaic
Hallberg-NOAA May 19, 2022
9a604d4
(*)Fix occasional bug with PFv_visc_rem diagnostic
Hallberg-NOAA May 20, 2022
27bb8b8
(*)Corrected OBC restart scaling bugs
Hallberg-NOAA May 29, 2022
203a19f
Fix a rescaling bug with MEKE_EQUILIBRIUM_ALT
Hallberg-NOAA May 29, 2022
37782eb
Fixes badge for doc build status
adcroft May 31, 2022
1ad842c
Replace findloc() with user-defined find_index
marshallward Jun 1, 2022
4a6a175
Bugfix: find_index in FMS2 infra
marshallward Jun 2, 2022
95119a2
(*)Fix ice shelf dimensional rescaling bugs
Hallberg-NOAA May 16, 2022
ec88923
Rescale ice shelf temperatures
Hallberg-NOAA May 22, 2022
c35da37
+Add user-controlled underflow of tracers
Hallberg-NOAA May 7, 2022
4288d41
Move underflow code into separate loops
Hallberg-NOAA Jun 3, 2022
aa86aba
Put CVMix convective viscosity into shear term
angus-g May 25, 2022
328c440
+Clean up dimensional rescaling in OBC code
Hallberg-NOAA Jun 3, 2022
cba297d
Merge branch 'main' into dev/gfdl
marshallward Jun 8, 2022
466ca80
Remove Travis CI config
marshallward Jun 8, 2022
551fbce
Merge branch 'dev/gfdl' into cvmix-conv-fix
marshallward Jun 11, 2022
c886ae7
Merge pull request #129 from angus-g/cvmix-conv-fix
Hallberg-NOAA Jun 12, 2022
e5580e3
Re-factored GFDL gitlab pipeline
adcroft Jun 8, 2022
546312a
Adds "makedep" script to replace mkmf
adcroft Apr 9, 2022
4bcc849
Makedep (#1)
marshallward Jun 14, 2022
8c605fe
(*)Internal thickness variable unit correction
Hallberg-NOAA May 4, 2022
79eb807
In the case that nonzero_count <=1, a (dummy) value is set for non_un…
Jun 6, 2022
0a8210a
+Add DEBUG_FULL_COLUMN for debugging accelerations
Hallberg-NOAA Jun 20, 2022
a824f80
+Convert 16 vertvisc_type pointers to allocatables
Hallberg-NOAA Jun 20, 2022
48adab7
+Add option to apply bottom drag as a body force
Hallberg-NOAA Jun 20, 2022
371c8bb
+Eliminated 3 unused elements of the surface type
Hallberg-NOAA Jun 13, 2022
835b166
(*)Use visc%Kv_shear in calculate_CVMix_conv call
Hallberg-NOAA Jun 13, 2022
d2d3236
Merge branch 'main' into main_to_dev
marshallward Jul 2, 2022
1e9febe
Fix PGI warnings about intent for restart_CS
adcroft Jun 15, 2022
12f2e55
gitlab-ci: add concurrent jobs in run stage
adcroft Jun 10, 2022
1c0e1f8
+Add set_initialized
Hallberg-NOAA Jun 20, 2022
e9e0f41
Merge branch 'dev/gfdl' into drag_as_body_force
Hallberg-NOAA Jul 6, 2022
5cadb72
Merge pull request #151 from Hallberg-NOAA/drag_as_body_force
marshallward Jul 7, 2022
cde444a
Re-developed makedep in python
adcroft Jul 2, 2022
5121534
makedep: fix for F90 includes
adcroft Jul 6, 2022
2581118
makedep: replaced includes_in_path() with list comprehension
adcroft Jul 6, 2022
9ecf1a6
makedep: Allow two versions of same file
adcroft Jul 6, 2022
1f64bf1
+Tiny fix to SIMPLE Northern OBC
kshedstrom Jun 20, 2022
c9dd804
MacOS support
marshallward Jun 22, 2022
58d704b
fix call to tridiagonal solver
Jun 21, 2022
43771d8
(*)Correct salinity rescaling in OBCs from files
Hallberg-NOAA Jul 8, 2022
48875ea
Fix to reading of partial OBCs from file.
kshedstrom Jul 13, 2022
9a3aa1e
Merge pull request #164 from ESMG/dev/esmg
marshallward Jul 15, 2022
4f039a8
+Fix diagnostic conversions in code from dev/ncar
Hallberg-NOAA Jul 14, 2022
c2e8465
*Fix DOME2d_initialize_temperature_salinity bug
Hallberg-NOAA Jul 13, 2022
05e705d
+*Use runtime parameters in DOME initialization
Hallberg-NOAA Jul 13, 2022
64fe4fc
Fix to dumbbell initialization in layer mode (#160)
WenhaoChen89 Jul 18, 2022
2217e63
+Restored public interface to post_data_1d_k
Hallberg-NOAA Jul 18, 2022
58db99b
+Overload MOM_tracer_chksum to use tracer registry
Hallberg-NOAA Jul 8, 2022
c8a6269
Added tracer debugging checksum calls
Hallberg-NOAA Jul 8, 2022
8ddd0c1
(*)Corrected OBC allocated tests in advect_y
Hallberg-NOAA Jul 8, 2022
c619781
(*)Fix set_up_ALE_sponge_field call T & S scaling
Hallberg-NOAA Jul 22, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,6 @@ coverage:
threshold: 100%
base: parent
comment:
# This must be set to the number of test cases (TCs)
after_n_builds: 8
# This is set to the number of TCs, plus unit, but can be removed
# (i.e. set to 1) when reporting is separated from coverage.
after_n_builds: 9
17 changes: 17 additions & 0 deletions .github/actions/macos-setup/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: 'install-macos-prerequisites'

description: 'Install prerequisites for Mac OS compilation'

runs:
using: 'composite'

steps:
- name: Install macOS packages
shell: bash
run: |
echo "::group::Install packages"
brew update
brew install automake
brew install netcdf
brew install mpich
echo "::endgroup::"
10 changes: 0 additions & 10 deletions .github/actions/testing-setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,6 @@ runs:
env
echo "::endgroup::"

- name: Install needed packages for compiling
shell: bash
run: |
echo "::group::Install linux packages"
sudo apt-get update
sudo apt-get install netcdf-bin libnetcdf-dev libnetcdff-dev mpich libmpich-dev
sudo apt-get install linux-tools-common
echo "::endgroup::"

- name: Compile FMS library
shell: bash
run: |
Expand All @@ -52,7 +43,6 @@ runs:
echo "FCFLAGS_DEBUG=-g -O0 -Wextra -Wno-compare-reals -fbacktrace -ffpe-trap=invalid,zero,overflow -fcheck=bounds" >> config.mk
echo "FCFLAGS_REPRO=-g -O2 -fbacktrace" >> config.mk
echo "FCFLAGS_INIT=-finit-real=snan -finit-integer=2147483647 -finit-derived" >> config.mk
echo "FCFLAGS_COVERAGE=--coverage" >> config.mk
cat config.mk
echo "::endgroup::"

Expand Down
19 changes: 19 additions & 0 deletions .github/actions/ubuntu-setup/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: 'install-ubuntu-prerequisites'

description: 'Install prerequisites for Ubuntu Linux compilation'

runs:
using: 'composite'
steps:
- name: Install Ubuntu Linux packages
shell: bash
run: |
echo "::group::Install linux packages"
sudo apt-get update
sudo apt-get install netcdf-bin
sudo apt-get install libnetcdf-dev
sudo apt-get install libnetcdff-dev
sudo apt-get install mpich
sudo apt-get install libmpich-dev
sudo apt-get install linux-tools-common
echo "::endgroup::"
2 changes: 2 additions & 0 deletions .github/workflows/coupled-api.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
with:
submodules: recursive

- uses: ./.github/actions/ubuntu-setup

- uses: ./.github/actions/testing-setup
with:
build_symmetric: 'false'
Expand Down
13 changes: 12 additions & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,18 @@ jobs:
with:
submodules: recursive

- uses: ./.github/actions/ubuntu-setup

- uses: ./.github/actions/testing-setup

- name: Compile unit testing
run: make -j build/unit/MOM6

- name: Run unit tests
run: make unit.cov.upload

- name: Compile MOM6 with code coverage
run: make -j build/cov/MOM6

- name: Run and post coverage
run: make run.symmetric -k -s
run: make run.cov -k -s
2 changes: 2 additions & 0 deletions .github/workflows/expression.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
with:
submodules: recursive

- uses: ./.github/actions/ubuntu-setup

- uses: ./.github/actions/testing-setup

- name: Compile MOM6 using repro optimization
Expand Down
34 changes: 34 additions & 0 deletions .github/workflows/macos-regression.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: MacOS regression

on: [pull_request]

jobs:
test-macos-regression:

runs-on: macOS-latest

env:
CC: gcc-11
FC: gfortran-11

defaults:
run:
working-directory: .testing

steps:
- uses: actions/checkout@v2
with:
submodules: recursive

- uses: ./.github/actions/macos-setup

- uses: ./.github/actions/testing-setup

- name: Compile reference model
run: make build.regressions MOM_TARGET_SLUG=$GITHUB_REPOSITORY MOM_TARGET_LOCAL_BRANCH=$GITHUB_BASE_REF DO_REGRESSION_TESTS=true -j

- name: Create validation data
run: make run.symmetric -k -s

- name: Regression test
run: make test.regression DO_REGRESSION_TESTS=true -k -s
34 changes: 34 additions & 0 deletions .github/workflows/macos-stencil.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: MacOS stencil tests

on: [push, pull_request]

jobs:
test-macos-stencil:

runs-on: macOS-latest

env:
CC: gcc-11
FC: gfortran-11

defaults:
run:
working-directory: .testing

steps:
- uses: actions/checkout@v2
with:
submodules: recursive

- uses: ./.github/actions/macos-setup

- uses: ./.github/actions/testing-setup

- name: Compile MOM6 in asymmetric memory mode
run: make build/asymmetric/MOM6 -j

- name: Create validation data
run: make run.symmetric -k -s

- name: Run tests
run: make test.grid test.layout test.rotate -k -s
2 changes: 2 additions & 0 deletions .github/workflows/other.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
with:
submodules: recursive

- uses: ./.github/actions/ubuntu-setup

- uses: ./.github/actions/testing-setup

- name: Compile with openMP
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/perfmon.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
with:
submodules: recursive

- uses: ./.github/actions/ubuntu-setup

- uses: ./.github/actions/testing-setup

- name: Compile optimized models
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/regression.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
with:
submodules: recursive

- uses: ./.github/actions/ubuntu-setup

- uses: ./.github/actions/testing-setup

- name: Compile reference model
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/stencil.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
with:
submodules: recursive

- uses: ./.github/actions/ubuntu-setup

- uses: ./.github/actions/testing-setup

- name: Compile MOM6 in asymmetric memory mode
Expand Down
Loading