(*) Bugfix: [uv]hml z-diags in general restrat #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The z-interpolated uhml and vhml diagnostics gave inconsistent answers across layouts when using the general mixed layer restratification scheme, because the value of h had changed but its halos had not been updated. This had been previously fixed in the BML restratification but not the general stratification method. This patch updates the value of h by conditionally updating the halos if this diagnostic is required.
adcroft
approved these changes
Aug 30, 2019
There was a problem hiding this comment.
Look good. Testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/8794
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The z-interpolated uhml and vhml diagnostics gave inconsistent answers
across layouts when using the general mixed layer restratification
scheme, because the value of h had changed but its halos had not been
updated.
This had been previously fixed in the BML restratification but not the
general stratification method.
This patch updates the value of h by conditionally updating the halos if
this diagnostic is required.