Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banana Pro support #96

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Banana Pro support #96

wants to merge 2 commits into from

Conversation

kothique
Copy link
Collaborator

@kothique kothique commented May 10, 2019

@momenso, do you think it should work?

There's a modification of bcm2835 that should work with Banana Pro: https://github.com/LeMaker/bcm2835_BP. The API is the same, so I simply choose which header to include and which library to link to depending on banana_pro flag.

I just have no idea what these things (from dht-sensor.cpp) are all about and if they are compatible with Banana Pro:

#define BCM2708_PERI_BASE   0x20000000
#define GPIO_BASE           (BCM2708_PERI_BASE + 0x200000)

Also we need to find someone with Banana Pro for testing.

Building

$ npm install --banana_pro=true

or

$ node-gyp configure -- -Dbanana_pro=true
$ node-gyp build

Things left to do

  • Test it on a real Banana Pro.
  • Update Reference for building from source and References in README.

@kothique kothique requested a review from momenso May 10, 2019 03:55
@kothique kothique self-assigned this May 10, 2019
@kothique kothique changed the title Banana Pro support Banana Pro (+Pi?) support May 10, 2019
@momenso
Copy link
Owner

momenso commented May 11, 2019

This might work. I agree we need to test it on an actual Banana Pi board, tough.

@kothique
Copy link
Collaborator Author

Seems like Banana Pro is a fake Banana Pi, and Lemaker infringes Banana Pi's trademark or something. I don't believe those "intellectual property" games are of any matter to us, and we still can support it, if someone gets a hold of the board.

@kothique kothique changed the title Banana Pro (+Pi?) support Banana Pro support May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants