Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf: Use computed offset passed in DateTime constructor #1576

Merged
merged 2 commits into from
Mar 9, 2024
Merged

Perf: Use computed offset passed in DateTime constructor #1576

merged 2 commits into from
Mar 9, 2024

Commits on Jan 20, 2024

  1. Add benchmark for DateTime.local with zone

    @schleyfox
    schleyfox committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    def2eac View commit details
    Browse the repository at this point in the history

  2. Use computed offset passed in DateTime constructor 

    All calls to the datetime constructor that pass an offset (o), have just
computed that offset (quickDT, fromObject) except for clone(). Clone
passes an "old" option to determine whether previous offset can be
reused. If we have config.o, but config.old is not set, then we can use
o without computing it.

This saves an expensive call to zone.offset that duplicates work that
was done immediately prior.
    @schleyfox
    schleyfox committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    5fa43cd View commit details
    Browse the repository at this point in the history