Skip to content

Guard against loading moment-timezone twice #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattjohnsonpint opened this issue May 7, 2015 · 1 comment
Closed

Guard against loading moment-timezone twice #212

mattjohnsonpint opened this issue May 7, 2015 · 1 comment

Comments

@mattjohnsonpint
Copy link
Contributor

A few reports from the wild, such as in #193 and on StackOverflow (and others) have shown that it's easy to accidentally load moment-timezone twice, which creates some problems.

Usually, it's a misunderstanding that moment-timezone-with-data already contains moment-timezone.

We should either guard against this, or at least prevent it from causing problems.

timrwood added a commit to timrwood/moment-timezone that referenced this issue May 12, 2015

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
mattjohnsonpint added a commit that referenced this issue May 13, 2015

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Log an error if moment timezone was already loaded. #212
@timrwood timrwood mentioned this issue May 30, 2015
@timrwood
Copy link
Member

timrwood commented Jun 1, 2015

This is released in 0.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants