Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time zone data: 2015c #205

Closed
wants to merge 1 commit into from

Conversation

mattjohnsonpint
Copy link
Contributor

@mattjohnsonpint
Copy link
Contributor Author

@timrwood - I built this by following
https://github.com/mj1856/moment-timezone/blob/master/contributing.md#compiling-data

The data looks good, but I'm not sure why it modified so many tests. Any ideas?

@mattjohnsonpint
Copy link
Contributor Author

Actually, it looks like it pulled in quite a lot of data changes. Were the previous files truncating history from some point?

@mattjohnsonpint
Copy link
Contributor Author

@ichernev @icambron @timrwood
Please help. we need to stay on top of tzdb updates, both here and on the momentjs.com/timezone website.

Is this one ok to merge? or did I screw it up somehow?

I need to now do it all over again for 2015d.

@icambron
Copy link
Member

icambron commented May 4, 2015

I actually have only passing familiarity with the whole TZ project, some I'm definitely not the guy to help you here.

@mattjohnsonpint
Copy link
Contributor Author

@icambron - Sure. I'll wait for @timrwood then. I'm tempted to just merge it...

@timrwood
Copy link
Member

Not sure why there are so many changes, I'm guessing it is a newline thing between windows and unix?

I opened another pr at #214 with the changes from 2015c and 2015d and the changes look to be substantially smaller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants