Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for timestamp formats when parsing #348

Merged
merged 1 commit into from
Sep 8, 2017
Merged

Check for timestamp formats when parsing #348

merged 1 commit into from
Sep 8, 2017

Conversation

joekrill
Copy link
Contributor

Unix timestamps were being parsed incorrectly when using 'x' or 'X' with moment.tz. The offset was being applied to the timestamp after the fact, actually changing the underlying timestamp. Fixes #347.

@mattjohnsonpint
Copy link
Contributor

Sorry for the delay. I'll review this soon. Thanks for your contribution!

@maggiepint
Copy link
Member

So, we are on a massively slow release cycle. That said, I think your change is correct. Is there any chance I can convince you to sign a CLA for this?

@joekrill
Copy link
Contributor Author

joekrill commented Aug 7, 2017

Of course, no problem. Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants