Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Node Error Logging #352

Merged
merged 1 commit into from
Dec 23, 2016
Merged

Remove Node Error Logging #352

merged 1 commit into from
Dec 23, 2016

Conversation

jonahkirangi
Copy link
Contributor

@jonahkirangi jonahkirangi commented May 29, 2016 •
edited
Loading

Remove console.log of multiple moment instances. Temporary patch for issue #231 until final solution has been implemented.

@jonahkirangi
Copy link
Contributor Author

Any thoughts on accepting this PR, @mj1856? Seems to be a highly requested change -- see #231.

@mattjohnsonpint
Copy link
Contributor

Needs some further evaluation, but I will try to make time for it soon. I do recognize the problem, and thanks for pinging me.

@maggiepint maggiepint merged commit e511cf0 into moment:develop Dec 23, 2016
@maggiepint
Copy link
Member

Released in 0.5.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonahkirangi @mattjohnsonpint @maggiepint