Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing build on non mac systems like linux #920

Closed
wants to merge 2 commits into from

Conversation

eramitmittal
Copy link

When TZ data is updated on linux using grunt data command, zdump output in case of no transition is not to the linking of grunt data-collect task. This fix ensures that usable zdump files get generated even in such cases

@ichernev
Copy link
Contributor

Can you give an example timezone that falls in this? Currently there is this inside collect, but what happens on length 13 is the question ;-) I also added the failed check (previous line).

Now the grunt task works well in the last few IANA releases.

@gilmoreorless
Copy link
Member

There were some cross-platform issues with the output of zdump. This solved one of them, but not all. I've done a wider sweep of the zdump-related code in #1059, which should fix this issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants