Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanish locale: del→de before year #1804

Closed
wants to merge 3 commits into from
Closed

Spanish locale: del→de before year #1804

wants to merge 3 commits into from

Conversation

rbonvall
Copy link
Contributor

The proper preposition before the year is «de». «del» is used informally for years after 2000, but «de» is still the preferred form. «del» doesn't really work for years before 2000.

Source: Spanish Royal Academy's Panhispanic Dictionary of Doubts.

@rbonvall
Spanish locale: del→de before year
b5b1d4d 
The proper preposition before the year is «de». «del» is used informally for years since 2000 but is not the proper form and cannot be used for years before 2000.
@rbonvall
Spanish locale tests: del→de before year
4c7c1b5
@ichernev
Copy link
Contributor

@julionc what do you think?

@ichernev
Copy link
Contributor

@rbonvall from this version we're using locale instead of lang. Can you please put the corresponding file/tests in locale, test/locale and change a few function calls. You can see how to convert here: #1807.

@julionc
Copy link
Contributor

julionc commented Aug 1, 2014

Good catch @rbonvall

@ichernev
When both are valid choices, which is preferable: de
According to this FAQ, the source confirms this.

@rbonvall
Copy link
Contributor Author

rbonvall commented Aug 4, 2014

Hi @ichernev, changes are already in locale, the patch is ready to be merged.

@ichernev
Copy link
Contributor

ichernev commented Aug 5, 2014

Thank you @rbonvall and @julionc!
This is ready for merge, I think it will go in the next patch release.

@ichernev ichernev added this to the 2.8.2 milestone Aug 5, 2014
ichernev added a commit to ichernev/moment that referenced this pull request Aug 20, 2014
@ichernev
Merge pull request moment#1804 from rbonvall/develop
d61ec6b 
Spanish locale: del→de before year

@changelog
@section lang-bugfix
@description del→de before year in spanish
@ichernev
Copy link
Contributor

Merged in d61ec6b

@ichernev ichernev closed this Aug 20, 2014
@kkirsche kkirsche mentioned this pull request Feb 10, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.2
Development

Successfully merging this pull request may close these issues.
3 participants
@rbonvall @ichernev @julionc