feat: makes clientside timeout setting name consistent w/ type (#65)

momentohq · Jan 28, 2023 · 03fc249 · 03fc249
1 parent 389b3f5
commit 03fc249
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/config/config.go b/config/config.go
@@ -17,9 +17,9 @@ type Configuration interface {
 	// GetClientSideTimeout Returns the current configuration options for client side timeout with the Momento service
 	GetClientSideTimeout() time.Duration
 
-	// WithClientTimeoutMillis Copy constructor for overriding TransportStrategy client side timeout. Returns a new Configuration object
-	// with the specified momento.TransportStrategy using passed client side timeout.
-	WithClientTimeoutMillis(clientTimeoutMillis time.Duration) Configuration
+	// WithClientTimeout Copy constructor for overriding TransportStrategy client side timeout. Returns a new
+	//Configuration object with the specified momento.TransportStrategy using passed client side timeout.
+	WithClientTimeout(clientTimeoutMillis time.Duration) Configuration
 }
 
 type SimpleCacheConfiguration struct {
@@ -46,7 +46,7 @@ func (s *SimpleCacheConfiguration) WithTransportStrategy(transportStrategy Trans
 	}
 }
 
-func (s *SimpleCacheConfiguration) WithClientTimeoutMillis(clientTimeout time.Duration) Configuration {
+func (s *SimpleCacheConfiguration) WithClientTimeout(clientTimeout time.Duration) Configuration {
 	return &SimpleCacheConfiguration{
 		transportStrategy: s.transportStrategy.WithClientTimeout(clientTimeout),
 	}

diff --git a/momento/simple_cache_client_test.go b/momento/simple_cache_client_test.go
@@ -228,7 +228,7 @@ func TestClientInitialization(t *testing.T) {
 			})
 			if tt.requestTimeout != nil {
 				c, err = NewSimpleCacheClient(&SimpleCacheClientProps{
-					Configuration:      config.LatestLaptopConfig().WithClientTimeoutMillis(*tt.requestTimeout),
+					Configuration:      config.LatestLaptopConfig().WithClientTimeout(*tt.requestTimeout),
 					CredentialProvider: testCredentialProvider,
 					DefaultTTLSeconds:  tt.defaultTTLSeconds,
 				})