fix: update if statement to determine cache already exists in test; c…

…hore: remove unused structs from external responses

momento/cache_operation_responses.go

@@ -1,23 +1,10 @@
 package momento
 
-import (
-	"github.com/momentohq/client-sdk-go/internal/models"
-	pb "github.com/momentohq/client-sdk-go/internal/protos"
-)
-
 type ListCachesResponse struct {
 	nextToken string
 	caches    []CacheInfo
 }
 
-func NewListCacheResponse(resp *pb.ListCachesResponse) *ListCachesResponse {
-	var caches = []CacheInfo{}
-	for _, cache := range resp.Cache {
-		caches = append(caches, NewCacheInfo(cache))
-	}
-	return &ListCachesResponse{nextToken: resp.NextToken, caches: caches}
-}
-
 func (resp *ListCachesResponse) NextToken() string {
 	return resp.nextToken
 }
@@ -34,10 +21,6 @@ func (ci CacheInfo) Name() string {
 	return ci.name
 }
 
-func NewCacheInfo(cache *pb.Cache) CacheInfo {
-	return CacheInfo{name: cache.CacheName}
-}
-
 const (
 	HIT  string = "HIT"
 	MISS string = "MISS"
@@ -48,22 +31,6 @@ type GetCacheResponse struct {
 	result string
 }
 
-func NewGetCacheResponse(resp *pb.GetResponse) (*GetCacheResponse, error) {
-	var result string
-	if resp.Result == pb.ECacheResult_Hit {
-		result = HIT
-	} else if resp.Result == pb.ECacheResult_Miss {
-		result = MISS
-	} else {
-		return nil, models.ConvertEcacheResult(models.ConvertEcacheResultRequest{
-			ECacheResult: resp.Result,
-			Message:      resp.Message,
-			OpName:       "GET",
-		})
-	}
-	return &GetCacheResponse{value: resp.CacheBody, result: result}, nil
-}
-
 func (resp *GetCacheResponse) StringValue() string {
 	if resp.result == HIT {
 		return string(resp.value)
@@ -86,10 +53,6 @@ type SetCacheResponse struct {
 	value []byte
 }
 
-func NewSetCacheResponse(resp *pb.SetResponse, value []byte) *SetCacheResponse {
-	return &SetCacheResponse{value: value}
-}
-
 func (resp *SetCacheResponse) StringValue() string {
 	return string(resp.value)
 }

momento/simple_cache_client_test.go

@@ -52,7 +52,7 @@ func setUp() (*ScsClient, error) {
 			err := client.CreateCache(&CreateCacheRequest{
 				CacheName: TestCacheName,
 			})
-			if !strings.Contains(err.Error(), scserrors.AlreadyExists) {
+			if err != nil && !strings.Contains(err.Error(), scserrors.AlreadyExists) {
 				return nil, err
 			}
 			return client, nil