Skip to content

Commit

Permalink
fix: Remove references to TEST_CACHE_NAME (#199)
Browse files Browse the repository at this point in the history
It's no longer used by the tests, it chooses its own unique cache names
to enable parallel testing.

For #187
  • Loading branch information
schwern authored and cprice404 committed Mar 14, 2023
1 parent bf2f40b commit b882550
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
8 changes: 2 additions & 6 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,12 @@ on:
workflow_call:
secrets:
auth-token:
description: 'Auth token used for live testing'
description: "Auth token used for live testing"
required: true
github-token:
description: 'Token for running Github actions'
description: "Token for running Github actions"
required: true


jobs:
test:
runs-on: ubuntu-20.04
Expand All @@ -19,7 +18,6 @@ jobs:
pull-requests: read
env:
TEST_AUTH_TOKEN: ${{ secrets.auth-token }}
TEST_CACHE_NAME: client-sdk-go-test-${{github.sha}}
steps:
- name: Setup repo
uses: actions/checkout@v3
Expand Down Expand Up @@ -54,5 +52,3 @@ jobs:
- name: Run test
run: make test


3 changes: 1 addition & 2 deletions CONTRIBUTING.template.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ Running `make precommit` will run all formatters, linters, and the tests. Run th

We use [Ginkgo](https://onsi.github.io/ginkgo/) and [Gomega](https://onsi.github.io/gomega/) to write our tests.

Integration tests require an auth token for testing. Set the env var `TEST_AUTH_TOKEN` to
provide it, you can get this from your `~/.momento/credentials` file. The env `TEST_CACHE_NAME` is also required, but for now any string value works.
Integration tests require an auth token for testing. Set the env var `TEST_AUTH_TOKEN` to provide it, you can get this from your `~/.momento/credentials` file.

Then run `make test`.

Expand Down

0 comments on commit b882550

Please sign in to comment.