Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add a CONTRIBUTING template. #112

Merged
merged 5 commits into from
Feb 14, 2023
Merged

docs: Add a CONTRIBUTING template. #112

merged 5 commits into from
Feb 14, 2023

Conversation

schwern
Copy link
Contributor

@schwern schwern commented Feb 14, 2023

Closes #86

@schwern
Copy link
Contributor Author

schwern commented Feb 14, 2023

@nidhidham This might be a good first issue to review. Try to follow the CONTRIBUTING document and let us know if there's anything missing.

@schwern schwern changed the title doc: Add a CONTRIBUTING template. docs: Add a CONTRIBUTING template. Feb 14, 2023
SDK has strict README-centric requirements which do not apply here.

Then run `make test`.

{{ossFooter}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need spaces around ossFooter to satisfy the github gods.

nand4011
nand4011 previously approved these changes Feb 14, 2023
cprice404
cprice404 previously approved these changes Feb 14, 2023
Copy link
Contributor

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

.github/workflows/on-pull-request.yml Show resolved Hide resolved
project_stability: alpha
project_type: other
sdk_language: Go
usage_example_path: ./examples/main.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, I don't think this will get used for non-SDK but I might be wrong about this one.

That's only for READMEs.
@schwern schwern dismissed stale reviews from cprice404 and nand4011 via 681814b February 14, 2023 19:13
@schwern schwern merged commit 0f385fe into main Feb 14, 2023
@schwern schwern deleted the issue/#86 branch February 14, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CONTRIBUTING document.
4 participants