Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set the output when generating the contributing file. #118

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

schwern
Copy link
Contributor

@schwern schwern commented Feb 14, 2023

I thought it would figure that out from the template.

Also requires momentohq/standards-and-practices#51

I thought it would figure that out from the template.
@pgautier404 pgautier404 self-requested a review February 14, 2023 21:56
pgautier404
pgautier404 previously approved these changes Feb 14, 2023
Tests cannot use a fixed cache name.
@cprice404 cprice404 merged commit 9ff180f into main Feb 14, 2023
@cprice404 cprice404 deleted the fix/contrib-generator branch February 14, 2023 22:13
cprice404 pushed a commit that referenced this pull request Mar 14, 2023
* fix: Set the output when generating the contributing file.

I thought it would figure that out from the template.

* fix: pubsub tests are colliding.

Tests cannot use a fixed cache name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants