Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds interface for SimpleCacheClient #125

Merged
merged 10 commits into from
Feb 15, 2023

Conversation

eaddingtonwhite
Copy link
Member

No description provided.

@eaddingtonwhite eaddingtonwhite marked this pull request as ready for review February 15, 2023 16:45
pgautier404
pgautier404 previously approved these changes Feb 15, 2023
Copy link
Contributor

@schwern schwern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a couple references to ScsClient. I'll fix them.

momento/simple_cache_client.go Outdated Show resolved Hide resolved
@schwern
Copy link
Contributor

schwern commented Feb 15, 2023

The list example is broken. I'll fix that.

@schwern schwern requested a review from pgautier404 February 15, 2023 17:41
Base automatically changed from issue/#115 to main February 15, 2023 17:47
pgautier404
pgautier404 previously approved these changes Feb 15, 2023
@schwern schwern merged commit 90bd07e into main Feb 15, 2023
@schwern schwern deleted the feat/adds-interface-to-scs-client branch February 15, 2023 18:07
cprice404 pushed a commit that referenced this pull request Mar 14, 2023
* ScsClient -> SimpleCacheClient
* feat: adds interface for SimpleCacheClient
---------

Co-authored-by: Michael G. Schwern <schwern@pobox.com>
Co-authored-by: eaddingtonwhite <5491827+ellery44@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants