Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add set operations #148

Merged
merged 5 commits into from
Feb 17, 2023
Merged

chore: add set operations #148

merged 5 commits into from
Feb 17, 2023

Conversation

pgautier404
Copy link
Contributor

No description provided.

@pgautier404 pgautier404 changed the title Add set operations chore: add set operations Feb 17, 2023
@schwern
Copy link
Contributor

schwern commented Feb 17, 2023

@pgautier404 LGTM, just that one thing.

schwern
schwern previously approved these changes Feb 17, 2023
@pgautier404 pgautier404 dismissed stale reviews from schwern and eaddingtonwhite via d690e8f February 17, 2023 20:54
pgautier404 and others added 4 commits February 17, 2023 12:57

Verified

This commit was signed with the committer’s verified signature.
h3ndrk Hendrik
Co-authored-by: Michael G. Schwern <schwern@pobox.com>
@pgautier404 pgautier404 merged commit da3e7b2 into main Feb 17, 2023
@pgautier404 pgautier404 deleted the add-set-operations branch February 17, 2023 21:08
cprice404 pushed a commit that referenced this pull request Mar 14, 2023
* chore: adding set operations

* chore: set remove ops and fix fetch values

* fix: tribute for the linter

* Update momento/set_remove_elements.go

Co-authored-by: Michael G. Schwern <schwern@pobox.com>

* fix: improve conversion method name

---------

Co-authored-by: Michael G. Schwern <schwern@pobox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants