fix: add testing for sets and some type fixes #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schwern
reviewed
Feb 22, 2023
* "returns a miss after overriding the client timeout with a short duration" needed a sleep to be reliable. * "returns a miss after the client default when refreshTTL is false" needed to create the Set before testing its refresh. The TTL will always be applied when creating a new Set. * Switch those tests to a more compact and complete testing style.
| @@ -278,7 +278,7 @@ func (c defaultScsClient) SetAddElement(ctx context.Context, r *SetAddElementReq | |||
| if err := c.dataClient.makeRequest(ctx, newRequest); err != nil { | |||
| return nil, err | |||
| } | |||
| return SetAddElementSuccess{}, nil | |||
| return &SetAddElementSuccess{}, nil | |||
eaddingtonwhite
approved these changes
Feb 22, 2023
cprice404
pushed a commit
that referenced
this pull request
Mar 14, 2023
* fix: add testing for sets and some type fixes * Fix the refreshTTL tests. * "returns a miss after overriding the client timeout with a short duration" needed a sleep to be reliable. * "returns a miss after the client default when refreshTTL is false" needed to create the Set before testing its refresh. The TTL will always be applied when creating a new Set. * Switch those tests to a more compact and complete testing style. * fix: seed set for collection ttl tests in BeforeEach * fix: prefer less verbose Expect --------- Co-authored-by: Michael G. Schwern <schwern@pobox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.