fix: inspect single field response to determine hit or miss #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| field: rtype.fields[0], | ||
| body: rtype.items[0].CacheBody, | ||
| }, nil | ||
| switch rtype.responses[0].(type) { |
There was a problem hiding this comment.
should we check length make sure we have 1 field returned here before trying to grab 0 index?
There was a problem hiding this comment.
The request is for exactly one field, so in this context it's safe as we know we got a hit. It's the same logic that is pulling the field and body properties out to populate the hit response.
There was a problem hiding this comment.
Yeah was just thinking be extra defensive not trust the API but I agree should not happen.
eaddingtonwhite
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.