chore: add dictionary testing #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Field: String(""), | ||
| Value: String("myValue"), | ||
| }), | ||
| ).Error().To(HaveMomentoErrorCode(InvalidArgumentError)) |
There was a problem hiding this comment.
maybe add case for nil also? I had made this ticket for nil Field or Value also so can wait till we do that if easier come back in one pass.
There was a problem hiding this comment.
Good call, I'll add that in a followup.
| Items: map[string]Value{"myField": String("myValue"), "": String("myOtherValue")}, | ||
| }), | ||
| ).Error().To(HaveMomentoErrorCode(InvalidArgumentError)) | ||
| }) |
There was a problem hiding this comment.
same here for nil check. Maybe just add TODO comment in test for now?
There was a problem hiding this comment.
Same, will follow up on this in my list testing PR.
eaddingtonwhite
approved these changes
Feb 25, 2023
There was a problem hiding this comment.
Awesome job on these @pgautier404 !! Loving the new test lib were using looks great.
cprice404
pushed a commit
that referenced
this pull request
Mar 14, 2023
* chore: adding dictionary tests * continuing testing * adjust for refactor and finish adding tests * TTL testing and test cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.