chore: convert cache client constructor to accept args #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgautier404
force-pushed
the
cache-client-constructor-args
branch
from
4f4eea9 to
7603164
Compare
pgautier404
force-pushed
the
cache-client-constructor-args
branch
2 times, most recently
from
1f7d4a2 to
badd12d
Compare
pgautier404
force-pushed
the
cache-client-constructor-args
branch
from
badd12d to
648b9f6
Compare
eaddingtonwhite
previously approved these changes
Mar 1, 2023
schwern
previously approved these changes
Mar 1, 2023
pgautier404
changed the title
pgautier404
dismissed stale reviews from schwern and eaddingtonwhite
via
b512984
eaddingtonwhite
approved these changes
Mar 1, 2023
cprice404
pushed a commit
that referenced
this pull request
Mar 14, 2023
* chore: convert cache client constructor to accept args vs. a props struct * change constructor argument name for consistency with other SDKs * more TTL -> Ttl renames * revert incorrect param name change * temporarily skip some sorted set tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the
NewCacheClientconstructor method so it accepts arguments for configuration, credential provider, and default TTL as discrete values instead of bundling them in a struct. This prevents users from passing in an empty struct with golang default values that guarantee the user a broken client. It also normalizesTTL->Ttlin camel cased identifiers.