Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Examples for recent renames and breaking changes #211

Merged
merged 1 commit into from
Mar 1, 2023
Merged

fix: Examples for recent renames and breaking changes #211

merged 1 commit into from
Mar 1, 2023

Conversation

schwern
Copy link
Contributor

@schwern schwern commented Mar 1, 2023

No description provided.

poppoerika
poppoerika previously approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@poppoerika poppoerika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating them!
I realized that too and updated in the upcoming PR but you beat me to it 🙇‍♀️

@poppoerika
Copy link
Contributor

I approved this PR since the test is only failing due to the recent breaking change in the backend not due to this PR.

@schwern schwern changed the base branch from main to fix/sorted-set-fetch March 1, 2023 19:58
@schwern schwern requested a review from poppoerika March 1, 2023 19:59
@schwern schwern force-pushed the fix/sorted-set-fetch branch from 97fbf58 to 49552e0 Compare March 1, 2023 21:41
Base automatically changed from fix/sorted-set-fetch to main March 1, 2023 23:09
@schwern
fix: Examples for recent changes.
bfb66db 
* CollectionTtl -> Ttl
* Topics having their own client.
* SimpleCacheClient -> CacheClient
* NewCacheClient taking individual args.
@schwern schwern changed the title fix: Examples for CollectionTtl -> Ttl and SimpleCacheClient -> CacheClient fix: Examples for recent renames and breaking changes Mar 1, 2023
@schwern schwern merged commit 8452200 into main Mar 1, 2023
@schwern schwern deleted the fix/examples branch March 1, 2023 23:34
cprice404 pushed a commit that referenced this pull request Mar 14, 2023
@schwern @cprice404
fix: Examples for recent changes. (#211)
904574a 
* CollectionTtl -> Ttl
* Topics having their own client.
* SimpleCacheClient -> CacheClient
* NewCacheClient taking individual args.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eaddingtonwhite eaddingtonwhite eaddingtonwhite approved these changes

@pgautier404 pgautier404 Awaiting requested review from pgautier404

@poppoerika poppoerika Awaiting requested review from poppoerika

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schwern @poppoerika @eaddingtonwhite