Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make sure all example methods accept momento.Value args #214

Merged
merged 1 commit into from
Mar 1, 2023
Merged

chore: make sure all example methods accept momento.Value args #214

merged 1 commit into from
Mar 1, 2023

Conversation

pgautier404
Copy link
Contributor

Closes #175

@pgautier404 pgautier404 merged commit 26dbd2b into main Mar 1, 2023
@pgautier404 pgautier404 deleted the standardize-on-value-args branch March 1, 2023 19:00
cprice404 pushed a commit that referenced this pull request Mar 14, 2023
@pgautier404 @cprice404
chore: make sure all example methods accept momento.Value args (#214)
3388ea2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eaddingtonwhite eaddingtonwhite eaddingtonwhite approved these changes

@poppoerika poppoerika Awaiting requested review from poppoerika

@schwern schwern Awaiting requested review from schwern

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit removeValue is the only list function that takes a momento.Value, the others take a strings
2 participants
@pgautier404 @eaddingtonwhite