Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move responses into their own package #222

Merged
merged 4 commits into from
Mar 3, 2023

Conversation

pgautier404
Copy link
Contributor

No description provided.

@pgautier404 pgautier404 force-pushed the refactor-response-types branch from 0dbd6ac to 20ea5b9 Compare March 3, 2023 01:39
@pgautier404 pgautier404 marked this pull request as ready for review March 3, 2023 01:48
@pgautier404 pgautier404 requested review from schwern, eaddingtonwhite, poppoerika and cprice404 and removed request for schwern and eaddingtonwhite March 3, 2023 01:48
@pgautier404 pgautier404 force-pushed the refactor-response-types branch from 20ea5b9 to 2ca23cc Compare March 3, 2023 01:49
// })
// }
// return convertedList
//}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pgautier404 mean to leave this here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not. I'll strip that out in a quick followup.

Copy link
Contributor

@poppoerika poppoerika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this was a lot of changes! Thank you for doing that.
Looks good to me.
I feel like we have been doing many breaking changes recently, so we need to audit and make sure we update the examples if needed before 1.0 release.
Do we have a ticket for that?

@pgautier404 pgautier404 merged commit f25b3b9 into main Mar 3, 2023
@pgautier404 pgautier404 deleted the refactor-response-types branch March 3, 2023 19:07
cprice404 pushed a commit that referenced this pull request Mar 14, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* chore: move responses into their own package

* list responses

* set responses

* sorted set responses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants