chore: add WARN, ERROR and TRACE log levels
#232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgautier404
reviewed
Mar 6, 2023
config/logger/builtin-logger.go
Outdated
Comment on lines
16
to
18
| if len(args) != 0 { | ||
| logWithArgs(l.level, l.loggerName, message, args...) | ||
| } else { |
There was a problem hiding this comment.
You can save a lot of code by just using one log method and checking len(args) there. There's no need for logWith and logWithout because variadic args are not required (which is how they can have a zero length).
schwern
suggested changes
Mar 6, 2023
config/logger/builtin-logger.go
Outdated
Comment on lines
26
to
30
| func (l *BuiltinMomentoLogger) Warn(message string, args ...string) { | ||
| if l.level == WARN { | ||
| momentoLog(l.level, l.loggerName, message, args...) | ||
| } | ||
| } |
There was a problem hiding this comment.
This means a warning will not show up if the log level is set to a more detailed log level. For example, if the level is TRACE it won't log a warning.
This is easier if the log levels are defined as numbers in order of severity. Then it's if l.level >= WARN.
schwern
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARN,ERRORandTRACElog levelsMomentoLoggerFactory'sGetLoggerto takelogLevelto log correctly based on a requested log levelMomentoLoggerfunctions to log based on a requested log levelTRACElogging when detecting an unrecognized response besidesDiscontinuity,Item, andHeartbeatfor topic subscriptionAlso
simple_cache_client.gotocache_client.go.Closes #157