feat: add key exists #243
Merged
feat: add key exists #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgautier404
requested review from
eaddingtonwhite,
cprice404,
poppoerika and
schwern
schwern
reviewed
Mar 8, 2023
momento/requester.go
Outdated
Comment on lines
131
to
113
| if key == nil || len(key.asBytes()) == 0 { | ||
| return nil, buildError(momentoerrors.InvalidArgumentError, "key cannot be nil or empty", nil) | ||
| } |
There was a problem hiding this comment.
Suggested change
| if key == nil || len(key.asBytes()) == 0 { | |
| return nil, buildError(momentoerrors.InvalidArgumentError, "key cannot be nil or empty", nil) | |
| } | |
| if err := validateNotEmpty(key, "key"); err != nil { | |
| return nil, err | |
| } |
There was a problem hiding this comment.
Good call, thanks. Updated in 974695c.
pgautier404
force-pushed
the
add-key-exists
branch
from
974695c to
2288c9e
Compare
pgautier404
force-pushed
the
add-key-exists
branch
from
2288c9e to
696b251
Compare
schwern
approved these changes
Mar 8, 2023
cprice404
pushed a commit
that referenced
this pull request
Mar 14, 2023
* feat: adding keys exist * add stub for test * lint fixes * correct test assertions * use validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.