feat: add support for signing keys APIs #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaddingtonwhite
previously requested changes
Apr 21, 2022
There was a problem hiding this comment.
@tylerburdsall this is awesome!! ❤️ were adding this to go sdk now also. Left some feed back but overall looking good.
Could we also try running golint and gofmt locally and check out put. It seems like were not totally compliant to me but hard to say for sure. Not sure if we need an extra cicd step maybe need to audit.
tylerburdsall
dismissed
eaddingtonwhite’s stale review
Changes have been addressed with latest commits, thank you for the feedback!
tylerburdsall
requested review from
kvcache,
virratanasangpunth,
wandaitzuchen and
mjindalmotiv8
wandaitzuchen
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
CreateSigningKey,RevokeSigningKey, andListSigningKeysAPIs