-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add logrus logging example #265
Conversation
This can't be merged until we have merged the corresponding logging changes from #264 , and done a release that this can point to. |
examples/go.mod
Outdated
) | ||
|
||
require ( | ||
cloud.google.com/go v0.105.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all the additions in here seem really surprising and wrong to me. I have no idea what caused them. Before I merge this PR I will try to restore them back to the previous form by hand and see if everything still builds, but if any of you all have ideas on how exactly I might have screwed this up please lmk :)
examples/go.mod
Outdated
go 1.19 | ||
|
||
replace github.com/momento/client-sdk-go => /Users/cprice/git/momento/client-sdk-go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These shouldn't be committed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, good call, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be fixed now
This commit adds an example that shows how to implement the Momento logging interface using the logrus logging framework, and some example code illustrating that the Momento log messages are successfully routed to logrus.
ceb72e2
to
5f365b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* feat: add logrus logging example This commit adds an example that shows how to implement the Momento logging interface using the logrus logging framework, and some example code illustrating that the Momento log messages are successfully routed to logrus.
This commit adds an example that shows how to implement the Momento logging interface using the logrus logging framework, and some example code illustrating that the Momento log messages are successfully routed to logrus.