Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logrus logging example #265

Merged
merged 3 commits into from
Mar 10, 2023
Merged

feat: add logrus logging example #265

merged 3 commits into from
Mar 10, 2023

Conversation

cprice404
Copy link
Contributor

This commit adds an example that shows how to implement the Momento logging interface using the logrus logging framework, and some example code illustrating that the Momento log messages are successfully routed to logrus.

@cprice404
Copy link
Contributor Author

This can't be merged until we have merged the corresponding logging changes from #264 , and done a release that this can point to.

examples/go.mod Outdated
)

require (
cloud.google.com/go v0.105.0 // indirect
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the additions in here seem really surprising and wrong to me. I have no idea what caused them. Before I merge this PR I will try to restore them back to the previous form by hand and see if everything still builds, but if any of you all have ideas on how exactly I might have screwed this up please lmk :)

examples/go.mod Outdated
Comment on lines 3 to 5
go 1.19

replace github.com/momento/client-sdk-go => /Users/cprice/git/momento/client-sdk-go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These shouldn't be committed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, good call, thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fixed now

Base automatically changed from more-logger-changes to main March 10, 2023 21:23

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This commit adds an example that shows how to implement the
Momento logging interface using the logrus logging framework,
and some example code illustrating that the Momento log messages
are successfully routed to logrus.
Copy link
Contributor

@pgautier404 pgautier404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cprice404 cprice404 merged commit 2fe47d0 into main Mar 10, 2023
@cprice404 cprice404 deleted the logrus-example branch March 10, 2023 22:23
cprice404 added a commit that referenced this pull request Mar 14, 2023
* feat: add logrus logging example

This commit adds an example that shows how to implement the
Momento logging interface using the logrus logging framework,
and some example code illustrating that the Momento log messages
are successfully routed to logrus.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants