Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add testing for newly added methods #272

Merged
merged 1 commit into from
Mar 11, 2023
Merged

chore: add testing for newly added methods #272

merged 1 commit into from
Mar 11, 2023

Conversation

pgautier404
Copy link
Contributor

No description provided.

malandis
malandis approved these changes Mar 11, 2023
View reviewed changes
Copy link
Contributor

@malandis malandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make note to add tests for...

  • put element: on an sorted set that doesn't exist, put overwrites, put bytes
  • get score: on a sorted set that doesn't exist; on a value that doesn't exist
  • same for get scores

@pgautier404
Copy link
Contributor Author

pgautier404 commented Mar 11, 2023 •
edited
Loading

Let's make note to add tests for...

* put element: on an sorted set that doesn't exist, put overwrites, put bytes

* get score: on a sorted set that doesn't exist; on a value that doesn't exist

* same for get scores

Totally, added in #273, thanks!

@pgautier404 pgautier404 merged commit a4f6284 into main Mar 11, 2023
@pgautier404 pgautier404 deleted the fill-in-sorted-set-testing branch March 11, 2023 01:03
cprice404 pushed a commit that referenced this pull request Mar 14, 2023
@pgautier404 @cprice404
chore: add testing for newly added methods (#272)
ccbbba1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malandis malandis malandis approved these changes

@cprice404 cprice404 Awaiting requested review from cprice404

@poppoerika poppoerika Awaiting requested review from poppoerika

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgautier404 @malandis