fix: simplify abstractions involved in sorted set get score #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cprice404
reviewed
Mar 13, 2023
responses/sorted_set_get_scores.go
Outdated
| isSortedSetScoreElement() | ||
| // ScoresFloat returns an array of float64 values that represent the hit responses. Misses | ||
| // are not represented the array. | ||
| func (r SortedSetGetScoresHit) ScoresFloat() []float64 { |
There was a problem hiding this comment.
should this be called ScoresArray? the scores are always floats, the difference between this accessor and the other one is the collection that you return them in.
There was a problem hiding this comment.
Good call, fixed in 0fa04e2.
cprice404
approved these changes
Mar 13, 2023
cprice404
pushed a commit
that referenced
this pull request
Mar 14, 2023
* fix: simplify abstractions involved in sorted set get elements * fix: fix accessor name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.