-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: run examples
in on-pull-request
workflow
#289
Conversation
I'm raising a flag here because we just went through this when a workflow to verify examples on pull requests was previously added (cc @eaddingtonwhite). It caused a ton of havoc and we ended up reverting the change. I really don't think we want to gate PRs on whether or not the examples build. We pin the SDK version in the examples exactly so we know that they work with the release they're pointed at, and we generally have a spike to bring examples up to spec each time we cut a new release. There shouldn't be an expectation in my opinion that the examples will always work with the HEAD of the repo. |
@pgautier404 |
i haven't had a chance to look at the code changes in this PR but that ^^ is the state of the art for how we are doing examples for now. |
@cprice404 Thank you for the explanation! |
This is what I was getting wrong (well, one of the things anyway), apologies. I had it in my head that the examples were being built against the latest commit, not the latest pinned version. You're right about that being the safe and standard way to do this. Sorry for the brain flatulence. In talking about this yesterday with @poppoerika I tracked down the commit that caused us so many problems, and it was actually adding the examples into the linting step that caused us so many problems we had to revert it in 8618c44. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #283