feat: add batch delete util #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgautier404
force-pushed
the
batch-delete-util
branch
4 times, most recently
from
bcd6948 to
6f31553
Compare
pgautier404
force-pushed
the
batch-delete-util
branch
from
6f31553 to
9367604
Compare
pgautier404
force-pushed
the
batch-delete-util
branch
2 times, most recently
from
b70fa43 to
9f70a7c
Compare
pgautier404
force-pushed
the
batch-delete-util
branch
from
9f70a7c to
065d880
Compare
cprice404
reviewed
Apr 6, 2023
batchutils/batch_operations.go
Outdated
| Key: myKey, | ||
| }) | ||
| if err != nil { | ||
| errChan <- fmt.Sprintf("error deleting key %s: %s", myKey, err.Error()) |
There was a problem hiding this comment.
just out of curiosity - is there a reason you decided to just push strings onto this channel rather than the actual errors?
There was a problem hiding this comment.
Mostly so they'd provide information about which keys failed.
There was a problem hiding this comment.
Your comment got me thinking, and I switched this up to use a map from failing key to error message instead in a6353c2. It ended up being a little more complicated to consume, and if you think its overcomplicated let me know.
cprice404
previously approved these changes
Apr 6, 2023
cprice404
approved these changes
Apr 6, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.