Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update README.md #295

Merged
merged 1 commit into from
Apr 10, 2023
Merged

chore: Update README.md #295

merged 1 commit into from
Apr 10, 2023

Conversation

NoSQLKnowHow
Copy link
Contributor

@NoSQLKnowHow NoSQLKnowHow commented Apr 5, 2023

chore: Fixed spelling of cache, added more comments, and updated the CLI commands to create a module.

@NoSQLKnowHow NoSQLKnowHow self-assigned this Apr 5, 2023
cprice404
cprice404 previously approved these changes Apr 5, 2023
Copy link
Contributor

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty

@cprice404
Copy link
Contributor

@NoSQLKnowHow - to fix the build failure you need to add chore: as a prefix to your PR title / commit message.

We have a validator that tries to ensure we are using conventional commit standards in all of our commits, which helps with tooling that generates release notes and changelogs.

@NoSQLKnowHow NoSQLKnowHow changed the title Update README.md chore: Update README.md Apr 5, 2023
Fixed spelling of cache, added more comments, and updated the CLI commands to create a module.
@cprice404 cprice404 merged commit 06e1e1c into main Apr 10, 2023
@cprice404 cprice404 deleted the NoSQLKnowHow-patch-3 branch April 10, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants