-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add increment
API
#308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈 other than I would like a test that covers a negative amount. Also, CI is red.
And I'm not really well versed with our go sdk so you should get Ellery and/or Pete to do final sign-off.
@@ -531,4 +531,167 @@ var _ = Describe("Scalar methods", func() { | |||
).To(BeAssignableToTypeOf(&DecreaseTtlMiss{})) | |||
}) | |||
}) | |||
|
|||
Describe("Increment", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should add a test that covers a negative value for amount.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this when @cprice404 is, but we need to figure out these test failures. If we've switched to V1 tokens for testing, I would expect these to fail and the tests need to be modified. Using legacy tokens, the credential provider's getAuthToken
method returns the auth token it was originally constructed with. For V1 tokens, however, getAuthToken
returns an api token extracted from the original, so they are no longer expected to match as the tests assert.
Added
increment
API along with tests to check:Closes #304