chore: by default support lazy connections #388
Merged
+43
−68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using the
Dial
method inside of grpc-go, the client automatically tries to connect to the server. This is not the default behavior that we want, and is not the default behavior of other grpc language impl.https://github.com/grpc/grpc-go/blob/99ded5c4905feb5d6ef305114c6f8a7a942011c7/clientconn.go#L222-L225
This pr addresses this by calling
NewClient
, which does not try to automatically connect to the server, unless aneagerConnection
is specified. If the user wants to eagerly connect (which is currently only an option for data plane client), then the behavior is unchanged