feat: add credential provider #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgautier404
force-pushed
the
add-credential-provider
branch
2 times, most recently
from
d66004a to
2e075b8
Compare
pgautier404
force-pushed
the
add-credential-provider
branch
from
2e075b8 to
182738d
Compare
| func NewUnaryDataGrpcManager(request *models.DataGrpcManagerRequest) (*DataGrpcManager, momentoerrors.MomentoSvcErr) { | ||
| config := &tls.Config{ | ||
| InsecureSkipVerify: false, | ||
| } | ||
| endpoint := fmt.Sprint(request.CredentialProvider.GetCacheEndpoint(), CachePort) |
There was a problem hiding this comment.
nit but would maybe write this w/ fmt.SprintF() instead keep port an Int like
const CachePort = 443
func NewUnaryDataGrpcManager(request *models.DataGrpcManagerRequest) (*DataGrpcManager, momentoerrors.MomentoSvcErr) {
...
endpoint := fmt.Sprintf("%s:%d", request.CredentialProvider.GetCacheEndpoint(), CachePort)
eaddingtonwhite
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
@pgautier404 this looks good to me for first step getting this in. Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.