feat: get sdk response types up to standards #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eaddingtonwhite
commented
Jan 27, 2023
eaddingtonwhite
commented
- removes signing key impl to break into its own package
eaddingtonwhite
requested review from
cprice404,
pgautier404,
tylerburdsall,
bruuuuuuuce and
poppoerika
cprice404
reviewed
Jan 27, 2023
There was a problem hiding this comment.
couple nits and I think maybe get @pgautier404 to review, otherwise lgtm
| // CacheGetResponse Base type for possible responses a cache GET can return. Miss || Hit | ||
| type CacheGetResponse struct { | ||
| responseType cacheGetResponseTypes | ||
| value []byte |
There was a problem hiding this comment.
so these are not accessible to users because they are lowercase, correct?
There was a problem hiding this comment.
correct :) golang!
tylerburdsall
previously approved these changes
Jan 27, 2023
pgautier404
reviewed
Jan 27, 2023
Co-authored-by: pgautier404 <pgautier404@users.noreply.github.com>
…sdk-go into feat/response-refactor
pgautier404
reviewed
Jan 27, 2023
pgautier404
reviewed
Jan 27, 2023
pgautier404
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.