chore: add check for context cancel or timeout #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgautier404
force-pushed
the
support-context-cancel
branch
from
05a9f22 to
b25894f
Compare
pgautier404
force-pushed
the
support-context-cancel
branch
from
b25894f to
3dd0ce8
Compare
pgautier404
force-pushed
the
support-context-cancel
branch
from
810cb83 to
de0f851
Compare
| } | ||
| time.Sleep(time.Second) | ||
| } | ||
|
|
||
| // Ensure cancelFunction is called to quiet a context leak warning | ||
| cancelFunction() |
There was a problem hiding this comment.
nit I think this is ok to leave as is. One thing you could do is right when cancelFunction is defined could call
defer cancelFunction() to ensure this is called when this overall function exits
There was a problem hiding this comment.
Ah, yes, gotcha. I'll make that change in a followup PR, thanks!
eaddingtonwhite
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.