fix(select): fix multi select popovers within parent popover #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisadubois
commented
Dec 12, 2024
| @@ -502,8 +540,6 @@ describe('Select', () => { | |||
| it('should have expected attributes set when shallowDisabled', async () => { | |||
| expect.assertions(2); | |||
|
|
|||
| const direction = 'top'; | |||
There was a problem hiding this comment.
this just wasn't used
peter7cole
approved these changes
Dec 13, 2024
robstax
approved these changes
Dec 13, 2024
| @@ -305,6 +306,84 @@ NestedPopover.args = { | |||
| ), | |||
| }; | |||
|
|
|||
| const MultipleSelectPopoversInsidePopoverInteractiveContentManaged = Template<PopoverProps>( | |||
|
🎉 This PR is included in version 26.184.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT
Currently, this project is closed to any external contributions. Any pull request made against this project from external sources will likely be closed. If you would like to make changes to this project, please fork this project.
Guide
This "Help" section can be deleted before submitting this pull request.
Update the name of this pull request to reflect the following shape:
Provide a general summary of the scope of the changes in this pull request.
Description
create a new plugin to handle tippy instances inside of a parent tippy instance. Unclear on why, but none of the existing event handling works to close other tippy instances specifically when there are 2 children tippys (as selects->popover). This is reproducible with a simple storybook (provided). I've also provided a story including the plugin fix. Unit tests have been provided and updated accordingly. The tippy plugin simply manages a map (which is optional) of the groups the children/sibling tippy instances should be associated to, and allows passing through from the select.
Links
Screen.Recording.2024-12-12.at.3.15.04.PM.mov