refactor(core-icons): removes division from icons #1196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes division from icons so that icons injested by momentum-react-v2 are compatible with dart-sass where division is deprecated
relevant cantina issue is spark 309091
Description
Basically take the division to a constant in each case. 2em/16 = .125em, etc. There is no actual change to the style, just removing division in a supported way.
Related Issue
Deprecation Warning: Sass Slashes #1176. http://github.com/momentum-design/momentum-ui/issues/1176#issue-1166023599
Motivation and Context
This allows Momentum React V2 to be upgraded to Dart Sass. Momentum React V2 imports the icons from the Momentum UI node module. The deprecated division throws an error while building the proposed changes to Momentum React V2.
How Has This Been Tested?
This is a simple change, since both are constants. Validated that the change is valid css, built with no errors.
Types of changes
Checklist: