Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): allow combobox the option to turn off filtering #1838

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

cormacmchale1
Copy link
Contributor

fixes an Inconsistancy in timepicker where multiple options cannot be seen by the User.

Description

Allowing the combo-box to turn on/off the filtering option. In the time-picker we use combo box for am/pm. We set the value explicitly, so when the User clicks on the am/pm dropdown, they are auto searching for that and hiding the other value. The use case here is to prevent that functionality when not required.

Related Issue

https://jira-eng-sjc12.cisco.com/jira/browse/CX-17005

Motivation and Context

Allows the component to be extensible for more use cases.

How Has This Been Tested?

Manually and in Unit tests.

Screenshots:

Before (If applicable):
Screenshot 2024-11-25 at 09 38 28

After:
Screenshot 2024-11-25 at 09 26 47

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

fixes an Inconsistancy in timepicker where multiple options cannot be seen by the User.
@NotNestor NotNestor merged commit 00c1b21 into momentum-design:main Nov 27, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants