Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable the global *:focus styles #966

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ccondry
Copy link
Contributor

@ccondry ccondry commented Jun 23, 2021

Description

Disable the *:focus styles, as they cannot be overridden or turned off like any other styles that have tag or class qualifiers.

Related Issue

#964

Motivation and Context

Remove global *:focus from the stylesheet. At the very least it would need additional qualifiers.

How Has This Been Tested?

I tested it in my own project, which is internal

Screenshots:

Before:
Screen Shot 2021-06-23 at 11 14 06 AM

After:
Screen Shot 2021-06-23 at 11 14 20 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant