Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(front): Save and restore path when logging in #1077

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

GordiNoki
Copy link
Member

Redirects user back to the path they were at when logging in. This was partially implemented in AuthGuard before, but didn't work well since AuthGuard only works on paths that require authentication.

Checks

  • !! DONT IGNORE ME !! I have ran nx run db:create-migration <name> and committed the migration if I've made DB schema changes
  • I have included/updated tests where applicable (see Testing)
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits

@GordiNoki GordiNoki requested a review from tsa96 November 28, 2024 15:29
Copy link
Member

@tsa96 tsa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, that's why this approach sounded so familiar - completely forgot I wrote this!

@tsa96 tsa96 merged commit 07c59f6 into main Nov 28, 2024
7 checks passed
@tsa96 tsa96 deleted the feat/return-url branch November 28, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants